From 783299963ae82e51decc80bf4a0177250e9f04cc Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Wed, 13 Dec 2017 18:04:12 -0800 Subject: [PATCH] RCFilters: Don't load JS or redirect when transcluding We were changing the URL on every page that contained {{Special:Recentchanges}}. Bug: T181032 Change-Id: Ib4a0d3c1733da0bd0076aa43b91fc06939c51b75 --- includes/specialpage/ChangesListSpecialPage.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php index b6d1028778..5993d10140 100644 --- a/includes/specialpage/ChangesListSpecialPage.php +++ b/includes/specialpage/ChangesListSpecialPage.php @@ -624,7 +624,7 @@ abstract class ChangesListSpecialPage extends SpecialPage { * redirect properly with all necessary query parameters. */ protected function considerActionsForDefaultSavedQuery() { - if ( !$this->isStructuredFilterUiEnabled() ) { + if ( !$this->isStructuredFilterUiEnabled() || $this->including() ) { return; } @@ -697,7 +697,7 @@ abstract class ChangesListSpecialPage extends SpecialPage { */ protected function includeRcFiltersApp() { $out = $this->getOutput(); - if ( $this->isStructuredFilterUiEnabled() ) { + if ( $this->isStructuredFilterUiEnabled() && !$this->including() ) { $jsData = $this->getStructuredFilterJsData(); $messages = []; @@ -1642,7 +1642,7 @@ abstract class ChangesListSpecialPage extends SpecialPage { ] ); $out->addModules( 'mediawiki.special.changeslist.legend.js' ); - if ( $this->isStructuredFilterUiEnabled() ) { + if ( $this->isStructuredFilterUiEnabled() && !$this->including() ) { $out->addModules( 'mediawiki.rcfilters.filters.ui' ); $out->addModuleStyles( 'mediawiki.rcfilters.filters.base.styles' ); } -- 2.20.1